Skip to content

Purge of unused resources in Render Graph #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 39 commits into from

Conversation

JulienIgnace-Unity
Copy link
Contributor

@JulienIgnace-Unity JulienIgnace-Unity commented Jun 5, 2020

Purpose of this PR

This PR adds purging of unused resource in RenderGraph.
Any texture not used for a frame is being deallocated. This prevents inflation of GPU memory cost when using some feature only for a time.
The current scheme (next frame purge) is a bit drastic but in theory, used resources should not change too much from one frame to another and only during level change and things like that.
We can explore adding script control to this in the future.

This PR needs #728 to be merged before review.


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)

Reduced error message spam when encountering an execution error.
Fixed a number of pass pruning issues.
This reverts commit 76a7c00.
JulienIgnace-Unity and others added 7 commits June 8, 2020 11:00
…Graphics into HDRP/rendergraph-enable-graphicstests

# Conflicts:
#	TestProjects/HDRP_Tests/Assets/GraphicTests/Scenes/9x_Other/9401_MSAAForwardOnly.unity
Disabled test 9401 for render graph after merge conflict.
…b.com/Unity-Technologies/Graphics into HDRP/rendergraph-resource-puge

# Conflicts:
#	com.unity.render-pipelines.core/Runtime/RenderGraph/RenderGraphResourceRegistry.cs
#	com.unity.render-pipelines.high-definition/Runtime/PostProcessing/PostProcessSystem.cs
…Graphics into HDRP/rendergraph-resource-puge

# Conflicts:
#	.yamato/all-hdrp.yml
#	.yamato/hdrp-linux-vulkan.yml
#	TestProjects/HDRP_Tests/Assets/GraphicTests/Scenes/4x_PostProcessing/4060_CustomPostProcess.unity
@JulienIgnace-Unity JulienIgnace-Unity deleted the HDRP/rendergraph-resource-puge branch July 8, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants