Skip to content

Touchup volume debug and gizmo color modification #7119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 16, 2022
Merged

Touchup volume debug and gizmo color modification #7119

merged 8 commits into from
Feb 16, 2022

Conversation

FrancescoC-unity
Copy link
Contributor

Two things that were raised during the review of the touchup volume.

1- Allow to customize colour and opacity of the volume gizmo

TouchupGizmo.mov

2- Add a debug view that shows as red the probes that have been touched by the touchup volume

debugview.mov

@FrancescoC-unity FrancescoC-unity self-assigned this Feb 11, 2022
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

adrien-de-tocqueville
adrien-de-tocqueville approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@adrien-de-tocqueville adrien-de-tocqueville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice debug mode

iM0ve
iM0ve approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@iM0ve iM0ve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also took a look at the new additions, all good no issues found.

What's tested:

  • Rebaked the ClassRoom project
  • Tried changing the touchup volume color
  • Tried using the new debug mode

Unity_jHDuXZcGIw

@FrancescoC-unity FrancescoC-unity merged commit 0f8ecd8 into master Feb 16, 2022
@FrancescoC-unity FrancescoC-unity deleted the HDRP/touchup-volume-debug branch February 16, 2022 17:19
PaulDemeulenaere pushed a commit that referenced this pull request Feb 16, 2022
@FrancescoC-unity @PaulDemeulenaere
Touchup volume debug and gizmo color modification (#7119)
921d80b 
* Tunable color

* Add debug mode

* Updating test data.

* Remove leftover that fails build

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@JulienIgnace-Unity JulienIgnace-Unity JulienIgnace-Unity approved these changes

@iM0ve iM0ve iM0ve approved these changes

@adrien-de-tocqueville adrien-de-tocqueville adrien-de-tocqueville approved these changes

Assignees

@FrancescoC-unity FrancescoC-unity

Labels
HDRP SRP testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FrancescoC-unity @sebastienlagarde @JulienIgnace-Unity @iM0ve @adrien-de-tocqueville