Skip to content

Adjustments Environment Lighting #6959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ValGrimm-U3D
Copy link
Contributor

HDRP-479 added a help box to the Environment tab of the Lighting window in HDRP. I have added the text from that help box to the documentation, and updated the screenshot of the menu (which was missing the volumetric clouds option).

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • [n/a ] Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • [n/a] Have you updated the changelog? Each package has a CHANGELOG.md file.
  • [n/a] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • [n/a] Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?
Updating the Environment Lighting page with the changes to the Environment tab of the Lighting Window in HDRP.


Testing status

Describe what manual/automated tests were performed for this PR
Not applicable.


Comments to reviewers

Notes for the reviewers you have assigned.
I added one sentence to the page which was approved in #6059, and updated the screenshot.

HDRP-479 added a help box to the Environment tab of the Lighting window in HDRP.  I have added the text from that help box to the documentation, and updated the screenshot of the menu (which was missing the volumetric clouds option).
@ValGrimm-U3D ValGrimm-U3D requested review from Vic-Cooper and adrien-de-tocqueville and removed request for Vic-Cooper February 2, 2022 14:16
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Feb 2, 2022
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@ValGrimm-U3D
Copy link
Contributor Author

@JulienIgnace-Unity Hi Julien, It seems that the option Static Lighting Volumetric Clouds isn't documented in the manual. What shall I write there?

@adrien-de-tocqueville I'm use the info from Julien's to add a description of the new Static Lighting Volumetric Clouds option to the manual, along with the sentence about the effect of directional light which belongs in that description.

@adrien-de-tocqueville
Copy link
Contributor

Yep, i restored the line you removed and improved the description of the option, i'll let julien review it

@ValGrimm-U3D
Copy link
Contributor Author

ValGrimm-U3D commented Feb 4, 2022

Yep, i restored the line you removed and improved the description of the option, i'll let julien review it

I am a bit confused. I did not remove a line; I updated the illustration, changed a name of an option in error as I missed than an option is undocumented and added a line to it from Julien's PR because it looked like an option was undocumented. I'm going to go ahead and close this PR and confer with Julien about what to do about the new option. Thanks!

@anisunity anisunity self-requested a review February 4, 2022 14:40
@adrien-de-tocqueville
Copy link
Contributor

adrien-de-tocqueville commented Feb 4, 2022

In the original version the line static lighting clouds was removed
image

But the option static lighting volumetric clouds is different although they have close names and it is indeed missing so the PR should be merged.
Addin @AnisB as he is responsible of volumetric clouds

@anisunity
Copy link
Contributor

@ValGrimm-U3D Please include me in volumetric clouds related changes, thanks!

@ValGrimm-U3D ValGrimm-U3D deleted the origin/HDRP/DOCG-10-Explicit-Sunlight-Revisions branch February 4, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants