-
Notifications
You must be signed in to change notification settings - Fork 839
Adjustments Environment Lighting #6959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjustments Environment Lighting #6959
Conversation
HDRP-479 added a help box to the Environment tab of the Lighting window in HDRP. I have added the text from that help box to the documentation, and updated the screenshot of the menu (which was missing the volumetric clouds option).
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
It appears that you made a non-draft PR! |
com.unity.render-pipelines.high-definition/Documentation~/Environment-Lighting.md
Outdated
Show resolved
Hide resolved
@JulienIgnace-Unity Hi Julien, It seems that the option Static Lighting Volumetric Clouds isn't documented in the manual. What shall I write there? @adrien-de-tocqueville I'm use the info from Julien's to add a description of the new Static Lighting Volumetric Clouds option to the manual, along with the sentence about the effect of directional light which belongs in that description. |
Yep, i restored the line you removed and improved the description of the option, i'll let julien review it |
I am a bit confused. I did not remove a line; I updated the illustration, changed a name of an option in error as I missed than an option is undocumented and added a line to it from Julien's PR because it looked like an option was undocumented. I'm going to go ahead and close this PR and confer with Julien about what to do about the new option. Thanks! |
In the original version the line static lighting clouds was removed But the option static lighting volumetric clouds is different although they have close names and it is indeed missing so the PR should be merged. |
@ValGrimm-U3D Please include me in volumetric clouds related changes, thanks! |
HDRP-479 added a help box to the Environment tab of the Lighting window in HDRP. I have added the text from that help box to the documentation, and updated the screenshot of the menu (which was missing the volumetric clouds option).
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*
label. After you backport the PR, the label changes tobackported-*
.CHANGELOG.md
file.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Updating the Environment Lighting page with the changes to the Environment tab of the Lighting Window in HDRP.
Testing status
Describe what manual/automated tests were performed for this PR
Not applicable.
Comments to reviewers
Notes for the reviewers you have assigned.
I added one sentence to the page which was approved in #6059, and updated the screenshot.