Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Backporting documentation URL fix for 1381488 #6667

Open
wants to merge 3 commits into
base: 2021.2/staging
Choose a base branch
from

Conversation

brett-groshong
Copy link
Contributor

@brett-groshong brett-groshong commented Dec 22, 2021

Please read the Contributing guide before making a PR.


Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?
Backport of documentation URL update for 1381488.
Original PR #6665

Testing status

Describe what manual/automated tests were performed for this PR
Opened in 2021.2.7f1 (current external) and verified that doc link works.

Screen Shot 2021-12-22 at 3 49 19 PM


Comments to reviewers

Notes for the reviewers you have assigned.

@brett-groshong brett-groshong changed the base branch from master to 2021.2/staging December 22, 2021 23:22
@github-actions
Copy link

github-actions bot commented Dec 22, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/jobDefinition/.yamato%2Fall-shadergraph_builtin_lighting.yml%23PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@brett-groshong brett-groshong marked this pull request as ready for review December 22, 2021 23:54
@brett-groshong brett-groshong requested a review from a team as a code owner December 22, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants