Skip to content

Fix missing depth on overlay camera DoF #6549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 9, 2021
Merged

Fix missing depth on overlay camera DoF #6549

merged 9 commits into from
Dec 9, 2021

Conversation

eh-unity
Copy link
Contributor

@eh-unity eh-unity commented Dec 9, 2021

Purpose of this PR

Fix bug case (https://issuetracker.unity3d.com/product/unity/issues/guid/1365623/)
Fix a code comment typo.

Testing status

Manually tested against bug repro project. Ran URPPostPro tests locally (pass).
Might need manual QA of overlay cameras and post processing, change could have halo effects.

sebastienlagarde and others added 7 commits December 7, 2021 11:57
@sebastienlagarde
Metal HDRP ref screenshots update (#6507)
cd397ac
@eh-unity
Fix typo in comment.
b66c806
@eh-unity
Fix overlay depth.
d27cf10
@eh-unity
Add test case.
c2e3067
@eh-unity
Fix missing depth for overlay DoF. Workaround MacOS depth as wirefram…
15b6a00 
…e driver bug.

URPasset has a depth texture checkbox, but that fixes the depth issue as well, but it's meant to be manual "force include depth" for case that can't be autodetected.
This one is correctly detected, but hardcode to not include depth (which is removed in this commit).
@eh-unity
Revert bug workaround. It's in another PR.
3bb95d5
@eh-unity
Revert "Add test case."
9f082ab 
This reverts commit c2e3067.
@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@eh-unity eh-unity marked this pull request as ready for review December 9, 2021 12:13
@eh-unity eh-unity requested review from a team as code owners December 9, 2021 12:13
@phi-lira
Copy link
Contributor

phi-lira commented Dec 9, 2021

Missing changelog.

@phi-lira phi-lira changed the base branch from master to universal/staging December 9, 2021 14:44
@phi-lira phi-lira merged commit 15cd26e into universal/staging Dec 9, 2021
@phi-lira phi-lira deleted the universal/fix-overlay-dof branch December 9, 2021 14:51
@phi-lira phi-lira mentioned this pull request Dec 9, 2021
Merged
@manuele-bonanno manuele-bonanno mentioned this pull request Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phi-lira phi-lira phi-lira approved these changes

@manuele-bonanno manuele-bonanno manuele-bonanno approved these changes

Assignees
No one assigned
Labels
universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eh-unity @phi-lira @manuele-bonanno @sebastienlagarde