Skip to content

Fix suggested names in Secondary Textures tab of Sprite Editor #6504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

kennytann
Copy link
Contributor


Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Code was accidentally removed during a refactor which removed suggested names from showing in the Sprite Editor


Testing status

Describe what manual/automated tests were performed for this PR

Open up a 2D URP Project.
Add a Sprite to the Project.
Open up Sprite Editor.
image

Navigate to Secondary Textures tab.
Add a secondary texture and ensure the suggested dropdown box is present with _MaskTex and _NormalMap
image


Comments to reviewers

Notes for the reviewers you have assigned.

@kennytann kennytann requested a review from unity-cchu December 7, 2021 07:39
@kennytann kennytann self-assigned this Dec 7, 2021
@kennytann kennytann requested review from a team as code owners December 7, 2021 07:39
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@BoonKiangTan
Copy link

BoonKiangTan commented Dec 9, 2021

Fix verified on branch:

2022.1.0b1.2464
Revision: trunk 4897ee769494
Built: Sat, 27 Nov 2021 21:58:31 GMT
Package branch: 2d/fix-suggested-names (c7aa761)

  • Verified secondary texture suggested dropdown box is present with _MaskTex and _NormalMap
    Unity_YJgeHGTxva

  • Verified normal map and mask tex still work as intended with URP pipeline
    Unity_ZZSOv3oK7u

@kennytann kennytann merged commit 8add63c into master Dec 10, 2021
@kennytann kennytann deleted the 2d/fix-suggested-names branch December 10, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants