Skip to content

Creating a new LODFade node that exposes the LODFade values #6468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions com.unity.shadergraph/Editor/Data/Nodes/Input/Scene/LODFadeNode.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
using System.Linq;
using UnityEngine;
using UnityEditor.Graphing;
using UnityEditor.ShaderGraph.Drawing.Controls;
using UnityEditor.ShaderGraph.Internal;

namespace UnityEditor.ShaderGraph
{
[Title("Input", "Geometry", "LOD Fade")]
class LODFadeNode : AbstractMaterialNode, IGeneratesBodyCode
{
public const int OutputSlotFadeId = 0;
public const int OutputSlotQuantizedId = 1;
const string kOutputSlotFadeName = "Fade";
const string kOutputSlotQuantizedName = "Quantized Fade";


public override bool hasPreview { get { return false; } }

public LODFadeNode()
{
name = "LOD Fade";
synonyms = new string[] { "fade", "disolve", "cross fade", "blend", "level of detail" };
UpdateNodeAfterDeserialization();
}

public sealed override void UpdateNodeAfterDeserialization()
{
AddSlot(new Vector1MaterialSlot(OutputSlotFadeId, kOutputSlotFadeName, kOutputSlotFadeName, SlotType.Output, 0, ShaderStageCapability.All));
AddSlot(new Vector1MaterialSlot(OutputSlotQuantizedId, kOutputSlotQuantizedName, kOutputSlotQuantizedName, SlotType.Output, 0, ShaderStageCapability.All));
RemoveSlotsNameNotMatching(new[] { OutputSlotFadeId, OutputSlotQuantizedId });
}

// Node generations
public virtual void GenerateNodeCode(ShaderStringBuilder sb, GenerationMode generationMode)
{
sb.AppendLine(string.Format("$precision {0} = unity_LODFade.x;", GetVariableNameForSlot(OutputSlotFadeId)));
sb.AppendLine(string.Format("$precision {0} = unity_LODFade.y;", GetVariableNameForSlot(OutputSlotQuantizedId)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know where unity_LODFade is defined? Is it always set/defined for all unity shaders?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unity_LODFade is define in the UnityPerDraw.
This is currently a good question. I guess it is always define in the context of shader graph (even for procedural geometry) as the other values like unity_SHAr. Doesn't mean the content of the value will make sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a way to guarantee that this node will handle situations where it isn't present-- but that's a separate problem. LGTM.

}
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.