Skip to content

[HDRP] Material scripting doc #6376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2021
Merged

[HDRP] Material scripting doc #6376

merged 1 commit into from
Nov 25, 2021

Conversation

AdrienDeTocqueville
Copy link
Contributor

@AdrienDeTocqueville AdrienDeTocqueville commented Nov 24, 2021 •
edited by adrien-de-tocqueville
Loading

Purpose of this PR

update material scripting doc
should replace #5688

Talked with docs team, they should finalize this by march, but agree to merge this in the meantime

@github-actions
Copy link

github-actions bot commented Nov 24, 2021 •
edited
Loading

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@adrien-de-tocqueville adrien-de-tocqueville marked this pull request as ready for review November 24, 2021 10:48
remi-chapelain
remi-chapelain approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✔️
Great addition.
This PR can be closed then when this one will be merged since the information have been included in this one.

@remi-chapelain remi-chapelain mentioned this pull request Nov 24, 2021
Closed
@JulienIgnace-Unity JulienIgnace-Unity merged commit c74d5ab into master Nov 25, 2021
@JulienIgnace-Unity JulienIgnace-Unity deleted the hd/material-scripting-doc branch November 25, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-chapelain remi-chapelain remi-chapelain approved these changes

@sebastienlagarde sebastienlagarde Awaiting requested review from sebastienlagarde

Assignees
No one assigned
Labels
Docs HDRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdrienDeTocqueville @remi-chapelain @JulienIgnace-Unity @adrien-de-tocqueville