Skip to content

Changes for using Embedded IR Tokens #6348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 23, 2021

Conversation

cdxntchou
Copy link

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

Copy link
Contributor

@joshua-davis joshua-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only worry is that you left AppendScopeName alone which has the hardcoded "Block" string which has to match how the ShaderBuilder is doing things. Not a blocker, but would be nice if we can guarantee these strings will be identical.

@cdxntchou cdxntchou marked this pull request as ready for review November 23, 2021 22:35
@cdxntchou cdxntchou requested a review from a team as a code owner November 23, 2021 22:35
Copy link
Contributor

@joshua-davis joshua-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough. We can worry about the declaration of the namespace at a later point.

Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdxntchou cdxntchou merged commit 1f9c977 into sg2/shader-sandbox Nov 23, 2021
@cdxntchou cdxntchou deleted the sg2/shader-sandbox-tokens branch November 23, 2021 23:21
joshua-davis pushed a commit that referenced this pull request Feb 2, 2022
* Changes for using Embedded IR Tokens

* Missing function

* Updating to call ShaderBuilder.DeclareStruct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants