Skip to content

[Shader Graph] Fix Various Property Duplication Issues #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions com.unity.shadergraph/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a bug where instanced shaders wouldn't compile on PS4.
- Optimized loading a large Shader Graph. [1209047](https://issuetracker.unity3d.com/issues/shader-graph-unresponsive-editor-when-using-large-graphs)
- Fixed NaN issue in triplanar SG node when blend goes to 0.
- Fixed an issue where Blackboard properties would not duplicate with `Precision` or `Hybrid Instancing` options.
- Fixed an issue where `Texture` properties on the Blackboard would not duplicate with the same `Mode` settings.
- Fixed an issue where `Keywords` on the Blackboard would not duplicate with the same `Default` value.

## [7.1.1] - 2019-09-05
### Added
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ internal override ShaderInput Copy()
{
displayName = displayName,
hidden = hidden,
value = value
value = value,
precision = precision,
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ internal override ShaderInput Copy()
displayName = displayName,
hidden = hidden,
value = value,
colorMode = colorMode
colorMode = colorMode,
precision = precision,
gpuInstanced = gpuInstanced,
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ internal override ShaderInput Copy()
{
displayName = displayName,
hidden = hidden,
value = value
value = value,
precision = precision,
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ internal override ShaderInput Copy()
{
displayName = displayName,
hidden = hidden,
value = value
value = value,
precision = precision
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ internal override ShaderInput Copy()
{
displayName = displayName,
hidden = hidden,
value = value
value = value,
precision = precision,
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ internal override ShaderInput Copy()
{
displayName = displayName,
hidden = hidden,
value = value
value = value,
precision = precision,
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ internal override ShaderInput Copy()
{
displayName = displayName,
hidden = hidden,
value = value
value = value,
precision = precision,
gpuInstanced = gpuInstanced,
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ internal override ShaderInput Copy()
displayName = displayName,
hidden = hidden,
overrideReferenceName = overrideReferenceName,
value = value
value = value,
precision = precision,
};
}
}
Expand Down
3 changes: 2 additions & 1 deletion com.unity.shadergraph/Editor/Data/Graphs/ShaderKeyword.cs
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ internal override ShaderInput Copy()
keywordType = keywordType,
keywordDefinition = keywordDefinition,
keywordScope = keywordScope,
entries = entries
entries = entries,
value = value,
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ internal override ShaderInput Copy()
{
displayName = displayName,
hidden = hidden,
value = value
value = value,
precision = precision,
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ internal override ShaderInput Copy()
{
displayName = displayName,
hidden = hidden,
value = value
value = value,
defaultType = defaultType,
precision = precision,
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ internal override ShaderInput Copy()
{
displayName = displayName,
hidden = hidden,
value = value
value = value,
precision = precision
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,9 @@ internal override ShaderInput Copy()
rangeValues = rangeValues,
enumType = enumType,
enumNames = enumNames,
enumValues = enumValues
enumValues = enumValues,
precision = precision,
gpuInstanced = gpuInstanced,
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ internal override ShaderInput Copy()
{
displayName = displayName,
hidden = hidden,
value = value
value = value,
precision = precision,
gpuInstanced = gpuInstanced,
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ internal override ShaderInput Copy()
{
displayName = displayName,
hidden = hidden,
value = value
value = value,
precision = precision,
gpuInstanced = gpuInstanced,
};
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ internal override ShaderInput Copy()
{
displayName = displayName,
hidden = hidden,
value = value
value = value,
precision = precision,
gpuInstanced = gpuInstanced,
};
}
}
Expand Down