[ShaderGraph] [2022.1] [Ruby] Fixing UIElements errors spewed because of a bad setting in the UXML file #6264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixing the error: "The PickingMode enum does not contain the value
Hidden
. Value must be in range [Position | Ignore]." when you open a ShaderGraph editor. This is causing lots of tests to fail as well, as the error is picked up by tests that open shadergraph editors.Seems like UIElements no longer silently ignores bad pickingmode settings, and will now complain.
Testing status
Tested opening shadergraph locally (PC D3D11 editor) -- no longer generates error.
Ran ShaderGraph edit mode and play mode tests (PC D3D11 editor) -- all pass.
Yamato:
PR ShaderGraph:
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/sg%252Ffix%252Fpicking-error-spew/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk/9860017/job/pipeline
Formatting failure appears to be from a previous PR in master (#6255)
Comments to reviewers
Notes for the reviewers you have assigned.