[2022.1][URP] Decal fixes #6239

lukaschod · 2021-11-08T09:27:59Z

Purpose of this PR
Fix cases:

Fixed decals to work with native render pass [case 1353141]
Fixing decals rendering to be correct with render scale [1353885]
Depends on #5369

Testing status
Tested if bugs no longer reproduce.

…f for that

…ted later on)

…be reverted later on)" This reverts commit 80af9be.

… code

… shaders to accommodate that

…rrect one

…r ConfigureTarget

…is handled

…ecals

…nologies/Graphics into universal/decal-fixes # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # com.unity.render-pipelines.universal/Runtime/RendererFeatures/DecalRendererFeature.cs

…t buffer in shader

…phics into universal/decal-fixes # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # com.unity.render-pipelines.universal/Runtime/Passes/CopyDepthPass.cs # com.unity.render-pipelines.universal/Runtime/Passes/ScriptableRenderPass.cs # com.unity.render-pipelines.universal/Shaders/Utils/CopyDepthPass.hlsl

…/Graphics into universal/decal-fixes

…g rendering

…for decals

…y-Technologies/Graphics into universal/depth-copy-as-color

…nologies/Graphics into universal/decal-fixes

…ncorrect depth buffer while on game view

…nologies/Graphics into universal/decal-fixes

…phics into universal/decal-fixes # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md

github-actions · 2021-11-08T09:28:12Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

github-actions · 2021-11-08T09:28:27Z

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

phi-lira

LGTM.

Failures are related to 035 terrain test being fixed in another PR.
Test 058 failure is due to reference image being wrong, already fixed on master.

jonuuukas and others added 30 commits July 29, 2021 11:02

switching _CameraDepthTexture to R32Float and accommodating some stuf…

a2e4eb6

…f for that

some changes to the Foundation Project for Repro project (to be rever…

80af9be

…ted later on)

Revert "some changes to the Foundation Project for Repro project (to …

d1cef12

…be reverted later on)" This reverts commit 80af9be.

disable fbfetch on DbufferDeferred decals

d39e96d

adding IsTransientAttachment to ScriptableRenderPass/NativeRenderPass…

c149ec9

… code

Fixed decals to work with native render pass [case 1353141]

8ce5f7c

Adding changelog entry

cdcc881

Leftover

14ec8d2

making depthOnly pass compatible to render color texture and changing…

933f089

… shaders to accommodate that

Merge branch 'master' into universal/depth-copy-as-color

624f0a1

Fixing decal+native renderpass+decal+deferred scenario

377d987

fix after updating trunk

d887392

merge fix - change descriptor for DepthOnly configureTarget to the co…

6accb1c

…rrect one

enabling depthbuffer for depth copy and adding additional override fo…

ee6e7d4

…r ConfigureTarget

formatting fixes

399ee75

terrain shader passes depthonly pass fix to output clippos

68d3938

adding depth copy for renderpass as well and changing how fake depth …

4f9cbd7

…is handled

some cleanup and refactoring and enabling Renderpass for SS forward d…

165f4d5

…ecals

Merge branch 'universal/depth-copy-as-color' of github.com:Unity-Tech…

4dead85

…nologies/Graphics into universal/decal-fixes # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # com.unity.render-pipelines.universal/Runtime/RendererFeatures/DecalRendererFeature.cs

Fixing decals rendering to be correct with render scale. [1353885]

4635bfb

Cleanup

b1ec31e

Cleanup

e8b738d

Cleanup

cc903b2

adding _OUTPUT_DEPTH keyword to CopyDepthPass to select correct outpu…

fd4df44

…t buffer in shader

Merge branch 'master' into universal/depth-copy-as-color

2510a18

adding depth output for VFXGraph depth only passes

5dec840

changing the semantic for outDepthColor in VFXPasses.template

c4ddd12

Changing to correct normal sampling for decal shadergraph

18e804f

Merge branch 'master' into universal/depth-copy-as-color

4deded8

lukaschod and others added 17 commits October 8, 2021 12:39

Changing image to correct texture type

d8b8989

Merge branch 'universal/decal-fixes' of github.com:Unity-Technologies…

4ec742f

…/Graphics into universal/decal-fixes

Merge branch 'master' into universal/depth-copy-as-color

f95fafb

fixing DBuffer Decals CopyDepth pass not copying the depth and failin…

159580e

…g rendering

adding fb fetch to Gbuffer decals and some other depth related fixes …

f9152cf

…for decals

Merge branch 'universal/depth-copy-as-color' of ssh://github.com/Unit…

b5a042f

…y-Technologies/Graphics into universal/depth-copy-as-color

fixing shader compilation error and renaming define for fb fetch idx

62ca66d

Merge branch 'universal/depth-copy-as-color' of github.com:Unity-Tech…

8315f67

…nologies/Graphics into universal/decal-fixes

Adding normal alpha multiplication with albedo alpha multiplication

a65c6c9

fix for RTIs non render pass platforms

fcb7d7f

another DeferredLights null check

427e0cb

null exception fix

850428a

adding some editor-specific code to avoid a bug with editor setting i…

70ad6ee

…ncorrect depth buffer while on game view

Merge branch 'universal/depth-copy-as-color' of github.com:Unity-Tech…

092200d

…nologies/Graphics into universal/decal-fixes

Merge branch 'universal/staging' of github.com:Unity-Technologies/Gra…

ce29a98

…phics into universal/decal-fixes # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md

Updating terrain 230 test templates from extra

d85820d

Updating test 230 images

aa33c68

lukaschod requested review from a team as code owners November 8, 2021 09:27

github-actions bot added testing universal labels Nov 8, 2021

Updating 230 vulkan images

a2c5f12

phi-lira approved these changes Nov 10, 2021

View reviewed changes

phi-lira changed the base branch from master to universal/staging November 10, 2021 08:52

Merge branch 'universal/staging' into universal/decal-fixes

5c2aaa7

phi-lira merged commit 8fb74d9 into universal/staging Nov 10, 2021

phi-lira deleted the universal/decal-fixes branch November 10, 2021 08:53

phi-lira mentioned this pull request Nov 10, 2021

Universal Staging Branch #6266

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[2022.1][URP] Decal fixes #6239

[2022.1][URP] Decal fixes #6239

Uh oh!

lukaschod commented Nov 8, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Nov 8, 2021

Uh oh!

github-actions bot commented Nov 8, 2021

Uh oh!

phi-lira left a comment

Uh oh!

Uh oh!

[2022.1][URP] Decal fixes #6239

[2022.1][URP] Decal fixes #6239

Uh oh!

Conversation

lukaschod commented Nov 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 8, 2021

Uh oh!

github-actions bot commented Nov 8, 2021

Uh oh!

phi-lira left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lukaschod commented Nov 8, 2021 •

edited

Loading