Skip to content

[Backport][2021.2][URP][2D] Fix performance regression where 2D alpha discard was broken #6224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2021
Merged

[Backport][2021.2][URP][2D] Fix performance regression where 2D alpha discard was broken #6224

merged 3 commits into from
Nov 12, 2021

Conversation

arttu-peltonen
Copy link
Contributor

@arttu-peltonen arttu-peltonen commented Nov 5, 2021 •
edited
Loading

Purpose of this PR

Backport #6219.

Testing status

Not tested with the backport version, original PR performance tested manually.

@arttu-peltonen
Fix regression where discard wasn't getting properly called in a 2D s…
bb90293 
…hader.

- Calling AlphaDiscard here is wrong because it requires _ALPHATEST_ON keyword to be enabled to work, and this keyword isn't used in 2D shaders.
@arttu-peltonen
Changelog
ff23f30
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%2Fall-urp.yml%23PR_URP_2021.2
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@arttu-peltonen arttu-peltonen self-assigned this Nov 5, 2021
@arttu-peltonen arttu-peltonen marked this pull request as ready for review November 5, 2021 14:32
@arttu-peltonen arttu-peltonen requested review from a team as code owners November 5, 2021 14:32
simon-engelbrecht-soerensen
simon-engelbrecht-soerensen approved these changes Nov 9, 2021
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing breaking, assuming performance improvement same as main PR.

@arttu-peltonen
Merge branch '2021.2/staging' into 2021.2/rpw/backport/1335648
ac66e15 
# Conflicts:
#	com.unity.render-pipelines.universal/CHANGELOG.md
@arttu-peltonen arttu-peltonen merged commit 7af75a5 into 2021.2/staging Nov 12, 2021
@arttu-peltonen arttu-peltonen deleted the 2021.2/rpw/backport/1335648 branch November 12, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-engelbrecht-soerensen simon-engelbrecht-soerensen simon-engelbrecht-soerensen approved these changes

@phi-lira phi-lira phi-lira approved these changes

@unity-cchu unity-cchu unity-cchu approved these changes

Assignees

@arttu-peltonen arttu-peltonen

Labels
2d universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arttu-peltonen @simon-engelbrecht-soerensen @phi-lira @unity-cchu