Skip to content

Reenable post process 2d graphics test #6171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kennytann
Copy link
Contributor


Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

This test was disable before to get builds to pass. Re-enabled to ensure unit test is in place.


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

@kennytann kennytann requested a review from unity-cchu October 29, 2021 04:40
@kennytann kennytann requested a review from a team as a code owner October 29, 2021 04:40
@kennytann kennytann self-assigned this Oct 29, 2021
@kennytann kennytann requested a review from a team as a code owner October 29, 2021 04:40
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@kennytann kennytann marked this pull request as draft November 22, 2021 02:16
@phi-lira
Copy link
Contributor

phi-lira commented Dec 9, 2021

This PR is failing on the PixelPerfect test on URP_2D on Android_OpenGLES3_Standalone_il2cpp_Linear on version trunk

Copy link
Contributor

@phi-lira phi-lira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failure in URP_2D on Android_OpenGLES3_Standalone_il2cpp_Linear on version trunk

@phi-lira phi-lira marked this pull request as ready for review December 9, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants