Skip to content

[Backport][1363763] Fix for pixel perfect cam post processing #6170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2021
Merged

[Backport][1363763] Fix for pixel perfect cam post processing #6170

merged 1 commit into from
Nov 3, 2021

Conversation

kennytann
Copy link
Contributor

@kennytann kennytann commented Oct 29, 2021 •
edited
Loading

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Backport fix for #6014

Testing status

Describe what manual/automated tests were performed for this PR

Run same test from original PR in 2021.2

Comments to reviewers

Notes for the reviewers you have assigned.

@kennytann
Fix invalid viewport being set during post process pass when using Pi…
863c317 
…xel Perfect Camera #6014

commit 8630c77
Author: Kenny Tan <kenny.tan@unity3d.com>
Date:   Thu Oct 14 14:28:46 2021 +0800

    Fix invalid viewport being set during post process pass when using pixel perfect camera

# Conflicts:
#	com.unity.render-pipelines.universal/CHANGELOG.md
#	com.unity.render-pipelines.universal/Runtime/2D/Renderer2D.cs
@kennytann kennytann requested a review from unity-cchu October 29, 2021 03:41
@kennytann kennytann self-assigned this Oct 29, 2021
@kennytann kennytann requested review from a team as code owners October 29, 2021 03:41
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%2Fall-urp.yml%23PR_URP_2021.2
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@kennytann kennytann changed the title Backport fix for pixel perfect cam post processing [Backport][1363763] Fix for pixel perfect cam post processing Oct 29, 2021
@kennytann kennytann added the 2d label Nov 1, 2021
@davidteo2d davidteo2d self-requested a review November 2, 2021 06:15
davidteo2d
davidteo2d approved these changes Nov 2, 2021
View reviewed changes
Copy link

@davidteo2d davidteo2d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on:
2021.2.0f1.3749.2
Revision: 2021.2/release 4bf1ec4b23c9
Built: Fri, 22 Oct 2021 08:05:02 GMT

Verified that:

  • With the provided bug project, the game display is no longer displays incorrectly when resized

simon-engelbrecht-soerensen
simon-engelbrecht-soerensen approved these changes Nov 2, 2021
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytann kennytann merged commit 575adaf into 2021.2/staging Nov 3, 2021
@kennytann kennytann deleted the 2021.2/2d/backport-fix-pixel-perfect-cam-post-processing branch November 3, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-engelbrecht-soerensen simon-engelbrecht-soerensen simon-engelbrecht-soerensen approved these changes

@unity-cchu unity-cchu unity-cchu approved these changes

@davidteo2d davidteo2d davidteo2d approved these changes

Assignees

@kennytann kennytann

Labels
2d universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennytann @simon-engelbrecht-soerensen @unity-cchu @davidteo2d