Skip to content

[RP Workflows][2021.2] Backport URP debug lighting fixes #6163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2021
Merged

[RP Workflows][2021.2] Backport URP debug lighting fixes #6163

merged 3 commits into from
Nov 5, 2021

Conversation

arttu-peltonen
Copy link
Contributor

@arttu-peltonen arttu-peltonen commented Oct 28, 2021 •
edited
Loading

Purpose of this PR

Backport two fixes to 2021.2:

Testing status

Verified smoothness fix works as expected on 21.2.0f1. HLSLcc fix is not in a published build yet so I didn't retest it locally.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%2Fall-urp.yml%23PR_URP_2021.2
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@arttu-peltonen arttu-peltonen self-assigned this Oct 28, 2021
@arttu-peltonen arttu-peltonen marked this pull request as ready for review October 28, 2021 11:14
@arttu-peltonen arttu-peltonen requested review from a team as code owners October 28, 2021 11:14
simon-engelbrecht-soerensen
simon-engelbrecht-soerensen approved these changes Nov 5, 2021
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arttu-peltonen
Copy link
Contributor Author

Yamato is green: 1 skipped and 157 successful checks

@arttu-peltonen
Merge branch '2021.2/staging' into 2021.2/rpw/backport/urp-debug-ligh…
065405f 
…ting-fixes

# Conflicts:
#	com.unity.render-pipelines.universal/CHANGELOG.md
@phi-lira phi-lira merged commit dbc56a7 into 2021.2/staging Nov 5, 2021
@phi-lira phi-lira deleted the 2021.2/rpw/backport/urp-debug-lighting-fixes branch November 5, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-engelbrecht-soerensen simon-engelbrecht-soerensen simon-engelbrecht-soerensen approved these changes

@phi-lira phi-lira phi-lira approved these changes

Assignees

@arttu-peltonen arttu-peltonen

Labels
universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arttu-peltonen @simon-engelbrecht-soerensen @phi-lira