Skip to content

Fix Light Loop Variant Warnings (1372256) #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Fix Light Loop Variant Warnings (1372256) #6135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f666dcb
Undefine the VARIANT before it gets redefined.
johnpars Oct 25, 2021
4ecf989
Changelog
johnpars Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed custom pass injection point not visible in the UI when using the Camera mode.
- Fixed film grain & dithering when using spatial upscaling methods for DRS.
- Fixed a regression that was introduced in the diffuse denoiser in a previous PR.
- Fixed a build-time warning regarding light loop variants (case 1372256).

### Changed
- Use RayTracingAccelerationStructure.CullInstances to filter Renderers and populate the acceleration structure with ray tracing instances for improved CPU performance on the main thread.
Expand Down
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/DeferredTile.shader
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ Shader "Hidden/HDRP/DeferredTile"
#endif

#ifndef SHADER_STAGE_FRAGMENT
#undef VARIANT // Prevent the chance of redefinition (1372256).
#define VARIANT 28
#endif

Expand Down