Skip to content

backport adaptive performance decals scaler #6069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

odbb
Copy link
Contributor

@odbb odbb commented Oct 19, 2021

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

This adds Adaptive Performance decal scaler support.


Testing status

Trunk PR: #6013

Manual Adaptive Performance tests - can be viewed in https://github.cds.internal.unity3d.com/unity/com.unity.adaptiveperformance/pull/118#


Comments to reviewers

Requires https://github.cds.internal.unity3d.com/unity/com.unity.adaptiveperformance/pull/118# - only works when Adaptive Performance is installed.

@odbb odbb requested a review from lukaschod October 19, 2021 17:28
@odbb odbb requested a review from a team as a code owner October 19, 2021 17:28
@odbb odbb self-assigned this Oct 19, 2021
@odbb odbb requested a review from a team as a code owner October 19, 2021 17:28
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Copy link
Contributor

@lukaschod lukaschod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phi-lira phi-lira merged commit a83a27c into 2021.2/staging Dec 7, 2021
@phi-lira phi-lira deleted the 2021.2/adaptive-performance/add-decals-scaler branch December 7, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants