Skip to content

Fix local fog volumes z axis calculation #6068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
109 changes: 101 additions & 8 deletions TestProjects/HDRP_RuntimeTests/Assets/Scenes/002-HDMaterials.unity
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,35 @@ MonoBehaviour:
m_CaptureRotation: {x: 0, y: 0, z: 0, w: 0}
m_FieldOfView: 0
m_Aspect: 0
m_SHForNormalization:
sh[ 0]: 0
sh[ 1]: 0
sh[ 2]: 0
sh[ 3]: 0
sh[ 4]: 0
sh[ 5]: 0
sh[ 6]: 0
sh[ 7]: 0
sh[ 8]: 0
sh[ 9]: 0
sh[10]: 0
sh[11]: 0
sh[12]: 0
sh[13]: 0
sh[14]: 0
sh[15]: 0
sh[16]: 0
sh[17]: 0
sh[18]: 0
sh[19]: 0
sh[20]: 0
sh[21]: 0
sh[22]: 0
sh[23]: 0
sh[24]: 0
sh[25]: 0
sh[26]: 0
m_HasValidSHForNormalization: 0
m_HDProbeVersion: 3
m_ObsoleteInfiniteProjection: 1
m_ObsoleteInfluenceVolume:
Expand Down Expand Up @@ -1203,7 +1232,7 @@ MonoBehaviour:
m_Script: {fileID: 11500000, guid: 172515602e62fb746b5d573b38a5fe58, type: 3}
m_Name:
m_EditorClassIdentifier:
isGlobal: 1
m_IsGlobal: 1
priority: 0
blendDistance: 0
weight: 1
Expand Down Expand Up @@ -1366,7 +1395,7 @@ MonoBehaviour:
invertFade: 0
distanceFadeStart: 10000
distanceFadeEnd: 10000
textureOffset: {x: -0, y: -0, z: 0}
textureOffset: {x: -0, y: -0, z: -0}
falloffMode: 0
m_Version: 2
--- !u!4 &289937389
Expand All @@ -1376,14 +1405,14 @@ Transform:
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 289937387}
m_LocalRotation: {x: 0.38268322, y: -0, z: -0, w: 0.9238797}
m_LocalRotation: {x: 0.9238792, y: -0, z: -0, w: 0.38268423}
m_LocalPosition: {x: -9.65, y: 14.476662, z: -13.446383}
m_LocalScale: {x: 2.2014, y: 2.2013998, z: 1.5467696}
m_ConstrainProportionsScale: 0
m_Children: []
m_Father: {fileID: 1576122520}
m_RootOrder: 12
m_LocalEulerAnglesHint: {x: 45.000004, y: 0, z: 0}
m_LocalEulerAnglesHint: {x: 135, y: 0, z: 0}
--- !u!1 &379148968
GameObject:
m_ObjectHideFlags: 0
Expand Down Expand Up @@ -2007,6 +2036,7 @@ Canvas:
m_OverridePixelPerfect: 0
m_SortingBucketNormalizedSize: 0
m_AdditionalShaderChannelsFlag: 0
m_UpdateRectTransformForStandalone: 0
m_SortingLayerID: 0
m_SortingOrder: 0
m_TargetDisplay: 0
Expand Down Expand Up @@ -3812,6 +3842,35 @@ MonoBehaviour:
m_CaptureRotation: {x: 0, y: 0, z: 0, w: 0}
m_FieldOfView: 0
m_Aspect: 0
m_SHForNormalization:
sh[ 0]: 0
sh[ 1]: 0
sh[ 2]: 0
sh[ 3]: 0
sh[ 4]: 0
sh[ 5]: 0
sh[ 6]: 0
sh[ 7]: 0
sh[ 8]: 0
sh[ 9]: 0
sh[10]: 0
sh[11]: 0
sh[12]: 0
sh[13]: 0
sh[14]: 0
sh[15]: 0
sh[16]: 0
sh[17]: 0
sh[18]: 0
sh[19]: 0
sh[20]: 0
sh[21]: 0
sh[22]: 0
sh[23]: 0
sh[24]: 0
sh[25]: 0
sh[26]: 0
m_HasValidSHForNormalization: 0
m_HDProbeVersion: 3
m_ObsoleteInfiniteProjection: 1
m_ObsoleteInfluenceVolume:
Expand Down Expand Up @@ -4301,6 +4360,7 @@ MonoBehaviour:
taaAntiFlicker: 0.5
taaMotionVectorRejection: 0
taaAntiHistoryRinging: 0
taaBaseBlendFactor: 0.875
physicalParameters:
m_Iso: 200
m_ShutterSpeed: 0.05
Expand Down Expand Up @@ -5460,6 +5520,7 @@ MonoBehaviour:
taaAntiFlicker: 0.5
taaMotionVectorRejection: 0
taaAntiHistoryRinging: 0
taaBaseBlendFactor: 0.875
physicalParameters:
m_Iso: 200
m_ShutterSpeed: 0.005
Expand Down Expand Up @@ -5723,7 +5784,7 @@ MonoBehaviour:
m_Script: {fileID: 11500000, guid: 172515602e62fb746b5d573b38a5fe58, type: 3}
m_Name:
m_EditorClassIdentifier:
isGlobal: 1
m_IsGlobal: 1
priority: 0
blendDistance: 0
weight: 1
Expand Down Expand Up @@ -6138,7 +6199,7 @@ LightingSettings:
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_Name:
serializedVersion: 3
serializedVersion: 5
m_GIWorkflowMode: 1
m_EnableBakedLightmaps: 1
m_EnableRealtimeLightmaps: 0
Expand All @@ -6151,7 +6212,7 @@ LightingSettings:
m_LightmapMaxSize: 1024
m_BakeResolution: 40
m_Padding: 2
m_TextureCompression: 1
m_LightmapCompression: 3
m_AO: 0
m_AOMaxDistance: 1
m_CompAOExponent: 1
Expand All @@ -6178,7 +6239,7 @@ LightingSettings:
m_LightProbeSampleCountMultiplier: 4
m_PVRBounces: 2
m_PVRMinBounces: 2
m_PVREnvironmentMIS: 1
m_PVREnvironmentImportanceSampling: 1
m_PVRFilteringMode: 1
m_PVRDenoiserTypeDirect: 1
m_PVRDenoiserTypeIndirect: 1
Expand All @@ -6192,6 +6253,7 @@ LightingSettings:
m_PVRFilteringAtrousPositionSigmaDirect: 0.5
m_PVRFilteringAtrousPositionSigmaIndirect: 2
m_PVRFilteringAtrousPositionSigmaAO: 1
m_PVRTiledBaking: 0
--- !u!1 &1521259788
GameObject:
m_ObjectHideFlags: 0
Expand Down Expand Up @@ -7134,6 +7196,35 @@ MonoBehaviour:
m_CaptureRotation: {x: 0, y: 0, z: 0, w: 0}
m_FieldOfView: 0
m_Aspect: 0
m_SHForNormalization:
sh[ 0]: 0
sh[ 1]: 0
sh[ 2]: 0
sh[ 3]: 0
sh[ 4]: 0
sh[ 5]: 0
sh[ 6]: 0
sh[ 7]: 0
sh[ 8]: 0
sh[ 9]: 0
sh[10]: 0
sh[11]: 0
sh[12]: 0
sh[13]: 0
sh[14]: 0
sh[15]: 0
sh[16]: 0
sh[17]: 0
sh[18]: 0
sh[19]: 0
sh[20]: 0
sh[21]: 0
sh[22]: 0
sh[23]: 0
sh[24]: 0
sh[25]: 0
sh[26]: 0
m_HasValidSHForNormalization: 0
m_HDProbeVersion: 3
m_ObsoleteInfiniteProjection: 1
m_ObsoleteInfluenceVolume:
Expand Down Expand Up @@ -7473,6 +7564,7 @@ MonoBehaviour:
taaAntiFlicker: 0.5
taaMotionVectorRejection: 0
taaAntiHistoryRinging: 0
taaBaseBlendFactor: 0.875
physicalParameters:
m_Iso: 200
m_ShutterSpeed: 0.005
Expand Down Expand Up @@ -7902,6 +7994,7 @@ Canvas:
m_OverridePixelPerfect: 0
m_SortingBucketNormalizedSize: 0
m_AdditionalShaderChannelsFlag: 0
m_UpdateRectTransformForStandalone: 0
m_SortingLayerID: 0
m_SortingOrder: 0
m_TargetDisplay: 0
Expand Down
Loading