Skip to content

Add camera type mask to Render Objects #5938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pbbastian
Copy link
Contributor

Purpose of this PR

Case 1361557 (public) identified an issue with the layer of objects in previews. This is being changed such that preview objects use layer 0 (Default) instead of layer 1 (TransparentFX). This means that renderer features might become active in the material preview. To allow for control over this, this PR is adding a mask for camera type to Render Objects. The feature will only run if the camera matches the mask.

image


Testing status

Tested functionality locally

@pbbastian pbbastian requested review from TheoWong-pixel and a team October 6, 2021 13:35
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@pbbastian pbbastian requested a review from oleks-k October 6, 2021 13:37
@TheoWong-pixel
Copy link

We should have analytics added to this renderer feature, in general, for all the fields. We may do another pass in the future to simplify the workflow / hide some of the settings under "additional settings"

analytics will be in a later PR.

Copy link
Contributor

@Verasl Verasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be under the 'event' property as the filter group is more for filtering of the objects themselves, less so the filtering/settings of the pass itself

@pbbastian pbbastian marked this pull request as ready for review October 7, 2021 09:56
@pbbastian pbbastian requested a review from a team as a code owner October 7, 2021 09:56
@pbbastian pbbastian requested a review from a team as a code owner November 25, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants