-
Notifications
You must be signed in to change notification settings - Fork 840
Histogram view improvements #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sebastienlagarde
merged 36 commits into
HDRP/staging
from
HDRP/histogram-view-improvements
May 28, 2020
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
68acb9c
some very incomplete stuff...
FrancescoC-unity ccb3a84
sync point, rough working version
FrancescoC-unity 297f0d4
Mostly working for now, moving onto debug vis and maybe revisit.
FrancescoC-unity d25ccf9
Commit as I need branch switching - Start debug modes
FrancescoC-unity 64cad47
Add a bunch of debug mode and start of histogram
FrancescoC-unity f2b71e0
Delimiters indicator with bars
FrancescoC-unity 86be36d
Add another option for percentile exttremes
FrancescoC-unity db33844
fix warning
FrancescoC-unity a277a56
Moving debug modes
FrancescoC-unity c533cfd
Label bar separate (invisible otherwise)
FrancescoC-unity 8cca38f
Push change to bar indicator
FrancescoC-unity f319156
remove fancy background of histogram frame
FrancescoC-unity 7fc3237
Small triangle instead of indicator bars
FrancescoC-unity 2573a9d
Target exposure indicator
FrancescoC-unity cda2dce
add some margin
FrancescoC-unity f5d1d79
Add an X at center
FrancescoC-unity cae8e6e
Metering PiP
FrancescoC-unity 2d59944
Draw tonemap curve and use tonemapped texture for view
FrancescoC-unity 7f83e1a
Share some code
FrancescoC-unity d002b89
Curve remapping for histogram and fix some warning
FrancescoC-unity 9187bbb
Some comments fixup
FrancescoC-unity beb9b39
Simple comment changes
FrancescoC-unity 9f7ee5f
Revert debug symbol in shader
FrancescoC-unity a544903
Changelog
FrancescoC-unity a330cb3
Merge branch 'HDRP/staging' into HDRP/histogram-exposure
sebastienlagarde 12632b6
review fixups
FrancescoC-unity e4345d8
Merge branch 'HDRP/histogram-exposure' of https://github.com/Unity-Te…
FrancescoC-unity b43f83a
print exposure values in debug view
FrancescoC-unity 6ca31ab
commit but it is nothing, need to switch branch
FrancescoC-unity 1f846b3
Add option to center histogram around exposure (fixed tonemap curve)
FrancescoC-unity 3601cfd
change color of text
FrancescoC-unity 4c29bd7
Merge branch 'HDRP/staging' into HDRP/histogram-view-improvements
FrancescoC-unity 61a7315
fixup debug display merge issue
FrancescoC-unity 64cf829
fixup merge issues
FrancescoC-unity de2cbb3
fixup issue with tonemap curve
FrancescoC-unity 7b7bf4e
Merge branch 'HDRP/staging' into HDRP/histogram-view-improvements
sebastienlagarde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.