Skip to content

[ShaderGraph][2021.2][Backport] Ensure blackboard ordering of subgraph properties on subgraph node #5716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2021

Conversation

jessebarker
Copy link
Contributor

Purpose of this PR

This PR fixes https://fogbugz.unity3d.com/f/cases/1366052/

It is a backport of #5700 and ensures that the ordering of inputs on a subgraph node follow the ordering of the properties on the actual subgraph.


Testing status

Same repro steps from the original fogbugz (https://fogbugz.unity3d.com/f/cases/1354463/)


Comments to reviewers

Notes for the reviewers you have assigned.

@jessebarker jessebarker requested a review from a team as a code owner September 17, 2021 17:36
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@Nightmask3 Nightmask3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, I notice the addition of the code that handles older files without the requisite category data generated, good looking out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants