Skip to content

[Backport] update of package samples that better reflect the feature set of 2021.2 #5711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Jonasmortensen
Copy link
Contributor

Backport of #5455

@Jonasmortensen Jonasmortensen requested review from a team as code owners September 17, 2021 13:09
@github-actions
Copy link

github-actions bot commented Sep 17, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@Jonasmortensen Jonasmortensen changed the base branch from master to 2021.2/staging September 17, 2021 13:09
@hdb-unity hdb-unity self-requested a review September 17, 2021 13:31
Copy link
Contributor

@hdb-unity hdb-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA testing complete.

Tested by importing samples into a new URP template project.

2 cosmetic issues raised, no shipstoppers found.

@Jonasmortensen Jonasmortensen merged commit 87238a1 into 2021.2/staging Sep 17, 2021
@Jonasmortensen Jonasmortensen deleted the 2021.2/universal/backport/package-samples-fixes branch September 17, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants