Skip to content

[Backport][ShaderGraph][2021.2][1357648] Fix bug that prevents switching to Graph Settings tab in Inspector when multiple nodes and edge are selected #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 17, 2021

Conversation

Nightmask3
Copy link
Contributor

Backport of #5699

Bug details here: https://fogbugz.unity3d.com/f/cases/1318844/

Notes:

Did not do manual testing as I'm currently on a build of trunk/2022.1, would appreciate a QA pass to ensure this is resolved in 2021.2 as well.

@Nightmask3 Nightmask3 requested a review from a team as a code owner September 16, 2021 23:40
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebarker jessebarker merged commit 4ad41d8 into 2021.2/staging Sep 17, 2021
@jessebarker jessebarker deleted the sg/backport-1357648-fix-2021.2 branch September 17, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants