Skip to content

fixed render settings setting incorrect cascade value, causing the wh… #5689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Verasl
Copy link
Contributor

@Verasl Verasl commented Sep 16, 2021

Purpose of this PR

This PR fixes a stall in the render settings converter when the user has no cascades checked in the Graphics tiers.


Testing status

Ran the converter on the Kart Racing learn project, going from builtin to URP with the disabled cascades


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@Verasl Verasl marked this pull request as ready for review September 16, 2021 16:25
@Verasl Verasl requested review from a team as code owners September 16, 2021 16:25
@martint-unity martint-unity merged commit 2189b0f into master Sep 17, 2021
@martint-unity martint-unity deleted the universal/bugfix/render-settings-converter-cascade branch September 17, 2021 05:16
@martint-unity
Copy link
Contributor

Merged it since we do not have any tests to run for this converter framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants