-
Notifications
You must be signed in to change notification settings - Fork 840
Universal RendererData GUID update - Test Projects #5683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Shader Graph VFX Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -9,7 +9,7 @@ MonoBehaviour: | |||
m_GameObject: {fileID: 0} | |||
m_Enabled: 1 | |||
m_EditorHideFlags: 0 | |||
m_Script: {fileID: 11500000, guid: f971995892640ec4f807ef396269e91e, type: 3} | |||
m_Script: {fileID: 11500000, guid: de640fe3d0db1804a85f9fc8f5cadab6, type: 3} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this thread and this backport PR
Correct me if I am wrong but this change is also expected on 2021.2/staging
?
This PR #5410 landed just before the 21.2 branch off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, will have to back port it quickly too to make sure less random failures for Yamato tests fro everyone
Purpose of this PR
There was an unintentional GUID change a while back in the URP codebase, unfortunately a lot of test projects updated to this GUID, this PR is to reverse them to make sure the URP Renderers are pointing to the correct UniversalRendererData.cs script.
Testing status
This was a bulk change as there are too many projects, I will run Yamato, but I am unsure how best to test other than manually checking all urp test projects which is too much for one single person.
Comments to reviewers
Notes for the reviewers you have assigned.