Skip to content

Universal RendererData GUID update - Test Projects #5683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

Verasl
Copy link
Contributor

@Verasl Verasl commented Sep 16, 2021

Purpose of this PR

There was an unintentional GUID change a while back in the URP codebase, unfortunately a lot of test projects updated to this GUID, this PR is to reverse them to make sure the URP Renderers are pointing to the correct UniversalRendererData.cs script.


Testing status

This was a bulk change as there are too many projects, I will run Yamato, but I am unsure how best to test other than manually checking all urp test projects which is too much for one single person.


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, it applies he meta inversion correction:
image

@@ -9,7 +9,7 @@ MonoBehaviour:
m_GameObject: {fileID: 0}
m_Enabled: 1
m_EditorHideFlags: 0
m_Script: {fileID: 11500000, guid: f971995892640ec4f807ef396269e91e, type: 3}
m_Script: {fileID: 11500000, guid: de640fe3d0db1804a85f9fc8f5cadab6, type: 3}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this thread and this backport PR
Correct me if I am wrong but this change is also expected on 2021.2/staging ?
This PR #5410 landed just before the 21.2 branch off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, will have to back port it quickly too to make sure less random failures for Yamato tests fro everyone

@Verasl Verasl marked this pull request as ready for review September 16, 2021 16:26
@Verasl Verasl requested review from a team as code owners September 16, 2021 16:26
@Verasl Verasl merged commit 85246cd into master Sep 16, 2021
@Verasl Verasl deleted the universal/rendererdata-guid-update branch September 16, 2021 16:27
Verasl added a commit that referenced this pull request Sep 16, 2021
ellioman pushed a commit that referenced this pull request Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants