[VFX] Fix new SG integration & Sample Texture/Buffer (to 21.2) #5605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix missing texture & buffer declaration While using new SG integration, the required textures weren't declared. TODO : Fix 35_ShaderGeneration, we are facing multiple definition WIP : I'm not sure about the side effect of this change & we need to register a fogbugz * *No change : add note * Fix initial solution from d0246e1 If a input is declared in SG, we have to skip it here. * Add graphicTest coverage (TODO : Update image references) * Update reference image for D3D TODO : Update OSX Image reference * Equivalent integration but move the responsability of filtering to subtarget * *Missing image reference update from D3D12 * Revert note in VFXShaderGraphParticleOutput.cs * Update changelog & Missing image reference * Missing WriteBuffer to support mesh sampling * Minor : Update Comment * Fix missing graphicsBuffer declaration Resolve issue #5416 (review) # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
julienf-unity
approved these changes
Sep 14, 2021
…texture-and-buffer-dependency
PaulDemeulenaere
deleted the
2021.2/vfx/fix/new-sg-integration-texture-and-buffer-dependency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Backport of #5416
Testing status
Yamato ⏳
Comments to reviewers
N/A