Skip to content

Vfx/fix/1291991 colorpicker keeps updating 2 #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2021
Merged

Vfx/fix/1291991 colorpicker keeps updating 2 #5587

merged 3 commits into from
Sep 13, 2021

Conversation

julienamsellem
Copy link
Contributor

Purpose of this PR

Revert this PR which was already a revert (so put back the initial PR in place)
#5122

Testing status

Tested with a Color Operator

Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@julienamsellem julienamsellem marked this pull request as ready for review September 10, 2021 12:04
PaulDemeulenaere
PaulDemeulenaere reviewed Sep 10, 2021
View reviewed changes
com.unity.visualeffectgraph/CHANGELOG.md Outdated
@@ -94,6 +94,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- GPU hang on some initialize dispatch during dichotomy (platform specific)
- Compilation error undeclared identifier 'Infinity' [Case 1328592](https://issuetracker.unity3d.com/product/unity/issues/guid/1328592/)
- Exposed Parameter placement can be moved after sanitize
- Eye dropper in the color fields kept updating after pressing the Esc key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should merge with master, this changelog entry is supposed to be in section 13.0.0 now

@PaulDemeulenaere PaulDemeulenaere self-requested a review September 13, 2021 14:35
PaulDemeulenaere
PaulDemeulenaere approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed initially, the requested change landed.
I also run Smoke_Test to verify the registered minimal unity version is approriate.
LGTM 🟢

@julienamsellem julienamsellem merged commit 4f302b6 into master Sep 13, 2021
@julienamsellem julienamsellem deleted the vfx/fix/1291991-colorpicker-keeps-updating-2 branch September 13, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulDemeulenaere PaulDemeulenaere PaulDemeulenaere approved these changes

Assignees
No one assigned
Labels
backported-2021.2 vfx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienamsellem @PaulDemeulenaere