-
Notifications
You must be signed in to change notification settings - Fork 840
Inspector Bugfixes #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspector Bugfixes #557
Conversation
# Conflicts: # com.unity.shadergraph/Editor/Data/Graphs/GraphData.cs
# Conflicts: # com.unity.shadergraph/Editor/Data/Graphs/GraphData.cs # com.unity.shadergraph/Editor/Drawing/Views/GraphEditorView.cs
…anup [skip ci] # Conflicts: # com.unity.shadergraph/Editor/Drawing/Inspector/PropertyDrawers/ShaderGUIOverridePropertyDrawer.cs # com.unity.shadergraph/Editor/Drawing/Views/GraphEditorView.cs # com.unity.shadergraph/Editor/Drawing/Views/MaterialNodeView.cs
…tor after deletion # Conflicts: # com.unity.shadergraph/Editor/Drawing/Inspector/PropertyDrawers/ShaderInputPropertyDrawer.cs
# Conflicts: # com.unity.shadergraph/Editor/Data/Nodes/AbstractMaterialNode.cs # com.unity.shadergraph/Editor/Drawing/Views/GraphEditorView.cs
…ctor # Conflicts: # com.unity.shadergraph/Editor/Drawing/Views/GraphEditorView.cs # com.unity.shadergraph/Editor/Drawing/Views/MaterialNodeView.cs # com.unity.shadergraph/Editor/Drawing/Views/PropertyNodeView.cs
…or and reordering targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snip, mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bottom scroll bar has the same problem as the side scrollbar, scrolling with it is impossible because the whole thing gives you a resize cursor
This branch was already merged into |
I see half of it giving you a resize cursor (which is annoying) but not the whole thing anymore. Please approve @LandonTownsendUnity. This needs to go in since we're not including Stacks in the first 10.0-preview drop. |
Purpose of this PR
This PR includes fixes for:
Testing status
Manual Tests
Comments to reviewers
If this is an issue I can add the code for them back in but the changes are fairly straightforward (i.e. the removal of the interface reference from all master nodes) and the functionality has been preserved. Eventually this code will be removed when master stacks lands regardless so the IHasSettings interface would need to be removed at some point.