Skip to content

[2021.2] Shader Stripping Improvements #5563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2021
Merged

[2021.2] Shader Stripping Improvements #5563

merged 1 commit into from
Sep 16, 2021

Conversation

lukaschod
Copy link
Contributor

Purpose of this PR

Backport #5060

Testing status

Describe what manual/automated tests were performed for this PR

@lukaschod lukaschod requested review from a team as code owners September 8, 2021 10:44
@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

eh-unity
eh-unity approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@eh-unity eh-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lukaschod
Copy link
Contributor Author

URP_Foundation on iPhone_Metal_Standalone_il2cpp_Linear on version 2021.2 https://unity-ci.cds.internal.unity3d.com/job/8773093

URP_Lighting on iPhone_Metal_Standalone_il2cpp_Linear on version 2021.2 https://unity-ci.cds.internal.unity3d.com/job/8773116

URP_Terrain instability

erikabar
erikabar approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original PR was tested extensively, so I'm approving without additional testing

@lukaschod lukaschod merged commit b2a6629 into 2021.2/staging Sep 16, 2021
@lukaschod lukaschod deleted the 2021.2/universal/shader-strip-improvements branch September 16, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikabar erikabar erikabar approved these changes

@eh-unity eh-unity eh-unity approved these changes

Assignees
No one assigned
Labels
testing universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaschod @erikabar @eh-unity