Vfx/fix/1327623 vfx recompiles for no change #5518
Conversation
It was resulting in always recompiling the vfx even if the value had not changed
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. VFX Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
| @@ -327,7 +327,7 @@ private bool SetSettingValueAndReturnIfChanged(string name, object value) | |||
| } | |||
|
|
|||
| var currentValue = setting.value; | |||
| if (currentValue != value) | |||
There was a problem hiding this comment.
The variables are of type object which leads to reference comparison instead of value comparison.
There was a problem hiding this comment.
LGTM
Your branch doesn't include this fix #5512
it explain this failure.
I'm more interested in test result in VFX_HDRP edit mode : https://unity-ci.cds.internal.unity3d.com/job/8629702 ⏳
Can you relaunch yamato after master merge (there is a known issue in edit mode https://unity.slack.com/archives/G1BTWN88Z/p1630664424058600?thread_ts=1630664357.058500&cid=G1BTWN88Z)
…or-no-change' into vfx/fix/1327623-vfx-recompiles-for-no-change
julienamsellem
deleted the
vfx/fix/1327623-vfx-recompiles-for-no-change
branch
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1327623/
When clicking on a block value but without changing the value the vfx was always recompiling
Testing status
Tested on the Capacity property
Comments to reviewers
Notes for the reviewers you have assigned.