Skip to content

Fix darkening in SSR fade #5472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2021
Merged

Fix darkening in SSR fade #5472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8710be2
Fix
FrancescoC-unity Aug 30, 2021
c5a294d
Changelog
FrancescoC-unity Aug 30, 2021
df1e00e
Merge branch 'hd/bugfix' into HDRP/fix-ssr-fade-darkening
sebastienlagarde Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a null ref exception when no opaque objects are rendered.
- Fixed issue with depth slope scale depth bias when a material uses depth offset.
- Fixed shadow sampling artifact when using the spot light shadow option 'custom spot angle'
- Fixed issue with fading in SSR applying fade factor twice, resulting in darkening of the image in the transition areas.

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
4 changes: 2 additions & 2 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/LightEvaluation.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,8 +630,8 @@ void ApplyScreenSpaceReflectionWeight(inout float4 ssrLighting)
{
// Note: RGB is already premultiplied by A for SSR
// TODO: check why it isn't consistent between SSR and RTR
float weight = _EnableRayTracedReflections ? 1.0 : ssrLighting.a;
ssrLighting.rgb *= ssrLighting.a;
float weight = _EnableRayTracedReflections ? ssrLighting.a : 1.0;
ssrLighting.rgb *= weight;
}
#endif

Expand Down