Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HDRP][DXR] Removed work-around on vertex color in ray tracing, after changes to the engine #5445

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

eturquin
Copy link
Contributor

Removed temp fix introduced by: #5268
after modifications to the engine that handle this case in a more robust manner: https://ono.unity3d.com/unity/unity/pull-request/130215
Vertex color (and other vertex-based attributes, like UVs, normals, etc.) are now defaulting to the same value in raster and ray-tracing. In the case of color, it is now defaulting to white instead of black.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde
Copy link
Contributor

please launch DXR test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants