Skip to content

Conversation

martint-unity
Copy link
Contributor


Purpose of this PR

There could be cases in where material was null and the converter would stop and throw errors. So this will let it continue.

There were ocations where this was null and the converter stopped.
@martint-unity martint-unity requested review from a team as code owners August 26, 2021 09:15
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@ellioman
Copy link
Contributor

This PR does not need run run through Yamato so I'm merging it.

@ellioman ellioman merged commit 3014c10 into master Aug 30, 2021
@ellioman ellioman deleted the universal/upgrader/fix-for-readonly-material-null-check branch August 30, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants