Skip to content

[URP] Decal fixes #5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Oct 7, 2021
Merged

[URP] Decal fixes #5384

merged 26 commits into from
Oct 7, 2021

Conversation

lukaschod
Copy link
Contributor

@lukaschod lukaschod commented Aug 18, 2021 •
edited
Loading

Purpose of this PR

Fix cases:

  • Fixed decals to work with native render pass [case 1353141]
  • Fixing decals rendering to be correct with render scale [1353885]

Depends on #5369

Testing status

Tested if bugs no longer reproduce.

jonuuukas and others added 20 commits July 29, 2021 11:02
@jonuuukas
switching _CameraDepthTexture to R32Float and accommodating some stuf…
a2e4eb6 
…f for that
@jonuuukas
some changes to the Foundation Project for Repro project (to be rever…
80af9be 
…ted later on)
@jonuuukas
Revert "some changes to the Foundation Project for Repro project (to …
d1cef12 
…be reverted later on)"

This reverts commit 80af9be.
@jonuuukas
disable fbfetch on DbufferDeferred decals
d39e96d
@jonuuukas
adding IsTransientAttachment to ScriptableRenderPass/NativeRenderPass…
c149ec9 
… code
@lukaschod
Fixed decals to work with native render pass [case 1353141]
8ce5f7c
@lukaschod
Adding changelog entry
cdcc881
@lukaschod
Leftover
14ec8d2
@jonuuukas
making depthOnly pass compatible to render color texture and changing…
933f089 
… shaders to accommodate that
@jonuuukas
Merge branch 'master' into universal/depth-copy-as-color
624f0a1
@lukaschod
Fixing decal+native renderpass+decal+deferred scenario
377d987
@jonuuukas
fix after updating trunk
d887392
@jonuuukas
merge fix - change descriptor for DepthOnly configureTarget to the co…
6accb1c 
…rrect one
@jonuuukas
enabling depthbuffer for depth copy and adding additional override fo…
ee6e7d4 
…r ConfigureTarget
@jonuuukas
formatting fixes
399ee75
@jonuuukas
terrain shader passes depthonly pass fix to output clippos
68d3938
@jonuuukas
adding depth copy for renderpass as well and changing how fake depth …
4f9cbd7 
…is handled
@jonuuukas
some cleanup and refactoring and enabling Renderpass for SS forward d…
165f4d5 
…ecals
@lukaschod
Merge branch 'universal/depth-copy-as-color' of github.com:Unity-Tech…
4dead85 
…nologies/Graphics into universal/decal-fixes

# Conflicts:
#	com.unity.render-pipelines.universal/CHANGELOG.md
#	com.unity.render-pipelines.universal/Runtime/RendererFeatures/DecalRendererFeature.cs
@lukaschod
Fixing decals rendering to be correct with render scale. [1353885]
4635bfb
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@lukaschod lukaschod marked this pull request as ready for review August 19, 2021 07:14
@lukaschod lukaschod requested review from a team as code owners August 19, 2021 07:14
@lukaschod lukaschod changed the title Universal/decal fixes Decal fixes Aug 19, 2021
@lukaschod lukaschod requested a review from ellioman August 19, 2021 07:21
erikabar
erikabar approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving without additional testing as developer already verified the fixes

@lukaschod lukaschod changed the title Decal fixes [URP] Decal fixes Aug 26, 2021
Base automatically changed from universal/depth-copy-as-color to universal/staging October 6, 2021 15:10
lukaschod and others added 2 commits October 7, 2021 09:48
@lukaschod
Merge branch 'universal/staging' of github.com:Unity-Technologies/Gra…
9319551 
…phics into universal/decal-fixes

# Conflicts:
#	com.unity.render-pipelines.universal/CHANGELOG.md
#	com.unity.render-pipelines.universal/Runtime/Passes/CopyDepthPass.cs
#	com.unity.render-pipelines.universal/Runtime/Passes/ScriptableRenderPass.cs
#	com.unity.render-pipelines.universal/Shaders/Utils/CopyDepthPass.hlsl
@phi-lira
Merge branch 'universal/staging' into universal/decal-fixes
1af0f36
@phi-lira phi-lira merged commit b4a7c94 into universal/staging Oct 7, 2021
@phi-lira phi-lira deleted the universal/decal-fixes branch October 7, 2021 07:20
@phi-lira phi-lira mentioned this pull request Oct 7, 2021
Merged
@lukaschod lukaschod restored the universal/decal-fixes branch October 8, 2021 09:36
phi-lira added a commit that referenced this pull request Oct 8, 2021
@phi-lira
Revert "[URP] Decal fixes (#5384)"
22a4669 
This reverts commit b4a7c94.
@lukaschod lukaschod mentioned this pull request Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellioman ellioman ellioman approved these changes

@erikabar erikabar erikabar approved these changes

Assignees
No one assigned
Labels
universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukaschod @ellioman @erikabar @phi-lira @jonuuukas