Skip to content

[HDRP][Path Tracing] Backport of sky+recorder fix #5001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2021
Merged

[HDRP][Path Tracing] Backport of sky+recorder fix #5001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e0051b
Make sure we know whether to render sky or not when recording.
eturquin Jun 29, 2021
d0a5cfc
Updated changelog.
eturquin Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fix for wrong cached area light initialization.
- Fixed an issue where enabling GPU Instancing on a ShaderGraph Material would cause compile failures [1338695].
- Fixed issue with velocity rejection when using physically-based DoF.
- Fixed issue with sky settings being ignored when using the recorder and path tracing (case 1340507).

### Changed
- Removed the material pass probe volumes evaluation mode.
Expand Down
11 changes: 7 additions & 4 deletions com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/PathTracing/PathTracing.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,18 @@ private void OnSceneGui(SceneView sv)

private void CheckDirtiness(HDCamera hdCamera)
{
// Grab the cached data for the current camera
int camID = hdCamera.camera.GetInstanceID();
CameraData camData = m_SubFrameManager.GetCameraData(camID);

if (m_SubFrameManager.isRecording)
{
// If we are recording, we still want to know whether sky rendering is enabled or not
camData.skyEnabled = (hdCamera.clearColorMode == HDAdditionalCameraData.ClearColorMode.Sky);
m_SubFrameManager.SetCameraData(camID, camData);
return;
}

// Grab the cached data for the current camera
int camID = hdCamera.camera.GetInstanceID();
CameraData camData = m_SubFrameManager.GetCameraData(camID);

// Check camera resolution dirtiness
if (hdCamera.actualWidth != camData.width || hdCamera.actualHeight != camData.height)
{
Expand Down