[SRP] Add Conditional field for shader code generation in Generate include command #4889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
sebastienlagarde
added a commit
that referenced
this pull request
Aug 5, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Aug 6, 2021
* Improved a bit the area cookie behavior for higher smoothness values to reduce artifacts. #3578 * [SRP] Add Conditional field for shader code generation in Generate include command #4889 * Fix VT Feedback buffer #4868 * [HDRP][Path Tracing] Backport of sky+recorder fix #5001 * [HDRP] Fix distortion when resizing the graphics compositor window in builds #5062 * Add compatibility with Unity 2020.3 for compositor resize callback * Small cleanup Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Yao Xiaoling <yao@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
[SRP] Add Conditional field for shader code generation in Generate include command
Example:
[SurfaceDataAttributes("Shadow Tint", false, true, preprocessor: "defined(_ENABLE_SHADOW_MATTE) && (SHADERPASS == SHADERPASS_PATH_TRACING)")]
public Vector4 shadowTint;
Generate on HLSL side
{
float3 color;
float3 normalWS;
#if defined(_ENABLE_SHADOW_MATTE) && (SHADERPASS == SHADERPASS_PATH_TRACING)
float4 shadowTint;
#endif
};
and for debug code it generate an empty field so it doesn't perturb the debug menu
#if defined(_ENABLE_SHADOW_MATTE) && (SHADERPASS == SHADERPASS_PATH_TRACING)
case DEBUGVIEW_UNLIT_SURFACEDATA_SHADOW_TINT:
result = surfacedata.shadowTint.xyz;
needLinearToSRGB = true;
break;
#else
case DEBUGVIEW_UNLIT_SURFACEDATA_SHADOW_TINT:
result = 0;
break;
#endif
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.