Skip to content

Re-enable cubemap thumbnail gen only for d3d11 #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2020
Merged

Re-enable cubemap thumbnail gen only for d3d11 #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b4f197
re-enable thumbnail gen only for d3d11
FrancescoC-unity May 14, 2020
0e176a2
Update changelog
FrancescoC-unity May 14, 2020
2b8e899
try enable metal
FrancescoC-unity May 14, 2020
d4a251d
Update changelog and comment
FrancescoC-unity May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed the MaxLightCount being displayed when the light volume debug menu is on ColorAndEdge.
- Fixed issue with unclear naming of debug menu for decals.
- Fixed z-fighting in scene view when scene lighting is off (case 1203927)
- Fixed issue that prevented cubemap thumbnails from rendering.
- Fixed issue that prevented cubemap thumbnails from rendering (only on D3D11 and Metal).
- Fixed ray tracing with VR single-pass
- Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer.
- Fixed error in the console when switching shader to decal in the material UI.
Expand Down
7 changes: 4 additions & 3 deletions com.unity.render-pipelines.high-definition/Editor/Lighting/Reflection/HDCubemapInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,12 @@ public override Texture2D RenderStaticPreview(string assetPath, Object[] subAsse
m_PreviewUtility.ambientColor = Color.black;
m_PreviewUtility.BeginStaticPreview(new Rect(0, 0, width, height));
m_PreviewUtility.DrawMesh(sphereMesh, Matrix4x4.identity, previewMaterial, 0);
// TODO: For now we comment this line as it cause out of memory on both DX12 and Vulkan API.
// TODO: For now the following line is D3D11 + Metal only as it cause out of memory on both DX12 and Vulkan API.
// We will need to invest time to understand what is happening
// For now priority is to enable Yamato platform automation
// This mean that cubemap icon will render incorrectly
//m_PreviewUtility.camera.Render();
// This mean that cubemap icon will render incorrectly on anything but D3D11
if(SystemInfo.graphicsDeviceType == GraphicsDeviceType.Direct3D11 || SystemInfo.graphicsDeviceType == GraphicsDeviceType.Metal)
m_PreviewUtility.camera.Render();

var outTexture = m_PreviewUtility.EndStaticPreview();

Expand Down