Skip to content

[HDRP] Fixed nullref when deleting the texture asset assigned in a local volumetric fog volume #4728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2021
Merged

[HDRP] Fixed nullref when deleting the texture asset assigned in a local volumetric fog volume #4728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4a4943
Fixed nullref when deleting the 3D mask of a density volume (case 133…
alelievr May 31, 2021
32601e7
Updated changelog
alelievr May 31, 2021
6a715ae
Merge branch 'hd/bugfix' into hd/fix/local-density-volume-delete-texture
sebastienlagarde May 31, 2021
c4b0429
Merge branch 'hd/bugfix' into hd/fix/local-density-volume-delete-texture
sebastienlagarde May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed path traced transparent unlit material (case 1335500).
- Fixed support of Distortion with MSAA
- Fixed contact shadow debug views not displaying correctly upon resizing of view.
- Fixed an error when deleting the 3D Texture mask of a local volumetric fog volume (case 1339330).

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
3 changes: 3 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/Texture3DAtlas.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,9 @@ public void Update(CommandBuffer cmd)
// Second pass to update elements where the texture content have changed
foreach (var element in m_TextureElementsMap.Values)
{
if (element.texture == null)
continue;

int newHash = GetTextureHash(element.texture);

if (element.hash != newHash)
Expand Down