Skip to content

[Fogbugz 1335732] Documentation and defaults for DLSS #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 29, 2021
Merged

[Fogbugz 1335732] Documentation and defaults for DLSS #4694

merged 7 commits into from
May 29, 2021

Conversation

kecho
Copy link
Contributor

@kecho kecho commented May 27, 2021 •
edited by iM0ve
Loading

Purpose of this PR

  • Setting up correct defaults for DLSS, current defaults are bad for UX because require more complexity to setup.
  • Improve the DLSS guide, which is missing a couple of steps. Also linking to the Dynamic Resolution Guide.

Fogbugz

Testing status

  • Run DLSS locally on windows with a brand new HDRP asset. Ensured that DLSS Use Optimal Settings is enabled by default.

pmavridis and others added 4 commits May 26, 2021 19:23
@pmavridis
[HDRP] Fix AxF debug output in certain configurations (#4641)
5945333 
* Fix AxF debug output in certain configurations.

* Update comment
@FrancescoC-unity @sebastienlagarde
Fix SSR accumulation white flash (#4648)
64a6c13 
* Fix white flash

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
@FrancescoC-unity @sebastienlagarde
Display Info Box when MSAA + ray tracing is onr (#4627)
f49b710 
* Show info box when ray tracing is enabled.

* Changelog

* Move below MSAA

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
@kecho
Documentation and defaults for DLSS
388482b
@kecho kecho marked this pull request as draft May 27, 2021 15:58
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

Vic-Cooper
Vic-Cooper requested changes May 27, 2021
View reviewed changes
Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small edits :)

...nity.render-pipelines.high-definition/Documentation~/deep-learning-super-sampling-in-hdrp.md Outdated
3. Enabling **Allow DLSS** exposes other properties that you can use to customize DLSS for the Camera. For information about these properties, see the [Camera](HDRP-Camera.md) documentation.
2. Select **Allow Dynamic Resolution** to expose the DLSS settings. For more information see the [Dynamic Resolution](Dynamic-Resolution.md) guide.
3. Select **Allow DLSS**.
4. Enabling **Allow DLSS** exposes other properties that you can use to customize DLSS for the Camera. For information about these properties, see the [Camera](HDRP-Camera.md) documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove passive voice:

Enable Allow DLSS to expose other properties that you can use to customize DLSS for the Camera.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! thank you.

...nity.render-pipelines.high-definition/Documentation~/deep-learning-super-sampling-in-hdrp.md
### DLSS and Dynamic Resolution

By default the [HDRP Assets](HDRP-Asset.md) has the **Use Optimal Settings** checkbox enabled. This means that DLSS will try and set the dynamic resolution scale automatically. If this checkbox is disabled,
DLSS will utilize the same dynamic resolution scale set by the project. For more information see the [Dynamic Resolution](Dynamic-Resolution.md) guide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small tweaks:

The Use Optimal Settings checkbox in the HDRP Asset is enabled by default. This means that DLSS sets the dynamic resolution scale automatically. If you disable this checkbox DLSS uses the same dynamic resolution scale set by the project. For more information see the Dynamic Resolution guide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! thank you.

iM0ve
iM0ve approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@iM0ve iM0ve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing sufficient. Looks all good.

@sebastienlagarde sebastienlagarde changed the base branch from hd/bugfix to master May 28, 2021 21:26
@sebastienlagarde sebastienlagarde changed the base branch from master to hd/bugfix May 28, 2021 21:27
@sebastienlagarde
Copy link
Contributor

note to self: retarget to master when hd/bugfix is merge

@sebastienlagarde sebastienlagarde changed the base branch from hd/bugfix to master May 29, 2021 19:53
@sebastienlagarde sebastienlagarde marked this pull request as ready for review May 29, 2021 19:54
@sebastienlagarde sebastienlagarde merged commit caee537 into master May 29, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/DlssDocsAndDefaults branch May 29, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vic-Cooper Vic-Cooper Vic-Cooper requested changes

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@iM0ve iM0ve iM0ve approved these changes

Assignees
No one assigned
Labels
HDRP SRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kecho @sebastienlagarde @iM0ve @Vic-Cooper @pmavridis @FrancescoC-unity