[URP][Converter Frame Work] Added priority to our converters #4670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed some UI layout issues
This is to conform with what we do elsewhere inside Unity. Lower numbers are more important :)
ellioman
approved these changes
May 27, 2021
svens-unity
approved these changes
May 27, 2021
com.unity.render-pipelines.universal/Editor/Converter/RenderPipelineConvertersEditor.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.universal/Editor/Converter/RenderPipelineConvertersEditor.cs
Show resolved
Hide resolved
com.unity.render-pipelines.universal/Editor/UniversalRenderPipelineMaterialUpgrader.cs
Show resolved
Hide resolved
…elineMaterialUpgrader.cs Co-authored-by: svens-unity <55388940+svens-unity@users.noreply.github.com>
removed reflection to get the property
martint-unity
changed the title
phi-lira
approved these changes
May 27, 2021
erikabar
approved these changes
May 27, 2021
CertifiedRice
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Adding a priority system to the converters.
This is needed so that we can have certain converters run before other converters.
There is also a few UI tweaks. Like paddings and such. Nothing that breaks. :)