Skip to content

Fix for discrepancies in saturation and intensity between screen space refraction and probe refraction #4653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2021
Merged

Fix for discrepancies in saturation and intensity between screen space refraction and probe refraction #4653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41270da
Delete the second transmittance mul
FrancescoC-unity May 26, 2021
3dd6120
Changelog
FrancescoC-unity May 26, 2021
e248dbe
Merge branch 'hd/bugfix' into HDRP/fix-refraction-discrepancies
sebastienlagarde May 29, 2021
7d9a0b5
Merge branch 'hd/bugfix' into HDRP/fix-refraction-discrepancies
sebastienlagarde May 29, 2021
6bbca98
Merge branch 'hd/bugfix' into HDRP/fix-refraction-discrepancies
sebastienlagarde May 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed invalid pass index 1 in DrawProcedural error.
- Fixed a compilation issue for AxF carpaints on Vulkan (case 1314040).
- Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904).
- Fixed for discrepancies in intensity and saturation between screen space refraction and probe refraction.

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Material/Lit/Lit.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2014,7 +2014,7 @@ IndirectLighting EvaluateBSDF_Env( LightLoopContext lightLoopContext,
lighting.specularReflected = envLighting;
#if HAS_REFRACTION
else
lighting.specularTransmitted = envLighting * preLightData.transparentTransmittance;
lighting.specularTransmitted = envLighting;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check we don't have the same issue in stacklit (iirc stacklit support refraction?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, looks like it is not supported

#endif

return lighting;
Expand Down