Skip to content

[Backport 8.x.x] Fixed some gcalloc in the debug window #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2020
Merged

[Backport 8.x.x] Fixed some gcalloc in the debug window #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de0d8c0
Fixed some GCAlloc in the debug window
JulienIgnace-Unity May 13, 2020
97ac528
Update changelog
JulienIgnace-Unity May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion com.unity.render-pipelines.core/Editor/Debugging/DebugUIDrawer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,12 @@ protected T Cast<T>(object o)
where T : class
{
var casted = o as T;
string typeName = o == null ? "null" : o.GetType().ToString();

if (casted == null)
{
string typeName = o == null ? "null" : o.GetType().ToString();
throw new InvalidOperationException("Can't cast " + typeName + " to " + typeof(T));
}

return casted;
}
Expand Down
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a null ref exception in static sky when the default volume profile is invalid.
- Fixed an error about procedural sky being logged by mistake.
- Fixed flickering of the game/scene view when lookdev is running.
- Fixed some GCAlloc in the debug window.

### Changed
- Shadowmask and realtime reflection probe property are hide in Quality settings
Expand Down