Skip to content

Fix issue causing not all baked reflection probes to be deleted #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed over consumption of GPU memory by the Physically Based Sky.
- Fixed an invalid rotation in Planar Reflection Probe editor display, that was causing an error message (case 1182022)
- Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.
- Fixed issue that caused not all baked reflection to be deleted upon clicking "Clear Baked Data" in the lighting menu (case 1136080)

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -471,8 +471,13 @@ void DeleteCubemapAssets(bool deleteUnusedOnly)
// Or we delete all assets
|| !deleteUnusedOnly)
{
// If the buffer is full we empty it and then push again the element we were trying to
// push but failed.
if (!buffer.TryPush(files[fileI]))
{
DeleteAllAssetsIn(ref buffer);
buffer.TryPush(files[fileI]);
}
}
}
}
Expand All @@ -489,6 +494,9 @@ static void DeleteAllAssetsIn(ref CoreUnsafeUtils.FixedBufferStringQueue queue)
while (queue.TryPop(out string path))
AssetDatabase.DeleteAsset(path);
AssetDatabase.StopAssetEditing();

// Clear the queue so that can be filled again.
queue.Clear();
}

internal static void Checkout(string targetFile)
Expand Down