Fix issue causing asset dependencies to be ignored #438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Import dependencies from the
Generator
class were being ignored due to re-assignment of list withoutout
. I changed it toAddRange
on the input list. Also bumped the importer version so that all Shader Graphs get re-imported and then have the dependencies setup correctly.The issue was introduced in this PR: https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/4940
Testing status
Manual Tests
To reproduce the issue, you can make any change to
com.unity.render-pipelines.universal/Editor/ShaderGraph/Targets/UniversalTarget.cs
and notice that without the fix it does not cause a re-import of Shader Graphs, even though it registers itself as a source dependency.You can also modify put a
Debug.Log
in here to see what ends up getting declared, and notice that without the fix it does not declare anything.https://github.com/Unity-Technologies/Graphics/blob/master/com.unity.shadergraph/Editor/Importers/ShaderGraphImporter.cs#L168