Add Volumetric Cloud Compatibility with MSAA #4345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add null check * changelog
* Remove unneeded position from input layout of light cluster * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…4313) * Skip adding the LOD's renderer to the checked renderer if it's null * changelog * Add LODgroup missing renderer to "check scene content for ray tracing" * formatting test * formatting Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…ind will be impacted (#4325) * Update doc * Fix doc
RemyUnity
approved these changes
Apr 28, 2021
|
Something bad have happen with hd/bugfix, I have delete and recreated the branch but then we have thing that should be there. those files aren't part of this PR: We will need to recreate this PR against a proper master, sorry about this .Will also allow us to do a proper review (this fix is for master only, so let's recreate pr for master) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix case: https://fogbugz.unity3d.com/f/cases/1327436/
Volumetric Clouds will fail in the case of MSAA color target. This is due to the in-place blending operation that occurs on the upscaling + combine pass (which can't be done on an MSAA target). This PR will move that combine to a subsequent pass after the upscaling, and instead do the blending via the hardware on the MSAA target.
Volumetric clouds now work in both scenarios:
No MSAA:
MSAA:
Testing status
Comments to reviewers
~