[Universal] fix case 1306432 material upgrade issue #3617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
ValentinHume
requested review from
ValentinHume
and removed request for
a team
ValentinHume
approved these changes
Mar 1, 2021
phi-lira
approved these changes
Mar 29, 2021
erikabar
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes an issue in where baseshadergui has an enum value that is reversed from our materials. So there is a mismatch causing some of our upgrades to have the wrong value.
FB case 1306432
Testing status
Tested with the testcase inside the FB case.
Comments to reviewers
This needs thorough testing with all differnet kind of materials that uses the smoothness source.