[VFX] Fix Mouse Event Binder in player #3411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix missing call to CreateVFXEventAttribute OnValidate is only called in editor, in runtime, we should init cache data with OnEnable * *Update changelog.md # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
Manually
Getting rid of error like : ```You are trying to read Input using the UnityEngine.Input class, but you have switched active Input handling to Input System package in Player Settings. stacktrace: UnityEngine.Input.get_mousePosition () (at <67986192636d462489158a112b065e02>:0) UnityEngine.UI.MultipleDisplayUtilities.GetMousePositionRelativeToMainDisplayResolution () (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/UI/Core/MultipleDisplayUtilities.cs:40)```
…e-and-fix-warning # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
This was referenced Feb 8, 2021
alelievr
approved these changes
Feb 8, 2021
PaulDemeulenaere
deleted the
vfx/fix/1290625-fix-event-binder-in-runtime-and-fix-warning
branch
PaulDemeulenaere
added
backported-10.x
backported-2021.1
and removed
needs-backport-10.x
needs-backport-2021.1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix this warning :
Registered at : https://fogbugz.unity3d.com/f/cases/1313003/
Testing status
Updating VFX_HDRP to use the new input system & cover this kind of warning.
Tested locally.
Comments to reviewers
This error should have been caught by the
csc.rspbut since the problematic code is inside#if INPUT_SYSTEMonly specific configurationGraphics/com.unity.visualeffectgraph/Runtime/Utilities/EventBinding/Implementation/VFXMouseEventBinder.cs
Line 48 in dfdf362
See also https://unity.slack.com/archives/CC68SH5SB/p1612536197008600