-
Notifications
You must be signed in to change notification settings - Fork 844
Fixed the display name of a Volume Parameter when is defined the attribute InspectorName #3348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sebastienlagarde
merged 1 commit into
master
from
HDRP/fix-InspectorName-VolumeComponents
Feb 5, 2021
Merged
Fixed the display name of a Volume Parameter when is defined the attribute InspectorName #3348
sebastienlagarde
merged 1 commit into
master
from
HDRP/fix-InspectorName-VolumeComponents
Feb 5, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSlysz
approved these changes
Feb 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test :)
com.unity.render-pipelines.core/Editor/Volume/VolumeComponentEditor.cs
Outdated
Show resolved
Hide resolved
jenniferd-unity
approved these changes
Feb 3, 2021
martint-unity
approved these changes
Feb 4, 2021
iM0ve
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats tested:
- Tested that InspectorName attribute is now used to display name, instead variable name previously.
- If InspectorName does not exist, the variable name is still used as fallback.
- Parameters are now correctly grouped using the Header attribute.
- Upgraded the project from Core to HDRP to see if there is any unexpected behaviour after update.
- For above testing the fogbuz sample was used, to verify that the users issue is gone
…ibute InspectorName
54751a1
to
30a0211
Compare
sebastienlagarde
pushed a commit
that referenced
this pull request
Feb 14, 2021
…ribute InspectorName #3348
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 3, 2021
…ibute InspectorName #3348
sebastienlagarde
added a commit
that referenced
this pull request
Mar 3, 2021
* Merge Hd/bugfix #3313 * Fix frame count in editor #3173 * Fixed the display name of a Volume Parameter when is defined the attribute InspectorName #3348 * Added the default quality settings to the HDRP asset for RTAO, RTR and RTGI (case 1304370). #3362 * Formatting * Windows vulkan reference screenshots Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The inspectors were shown like this:
When the user has defined them like this:
So the attribute
InspectorName
was not properly readed to show the correct label for those properties.After the changes in this PR, they appear correctly.
Testing status
Comments to reviewers
It was missing an entry to check the
InspectorNameAttribute
, I've changed it to be a switch, and I extracted it to a method to be able to call it from a Unity test.Comments for QA
Grab the test project from here
and check the
TestVolumeComponent
on the inspector.