Skip to content

Mention in TAA doc that a certain use case will lead to problems. #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Mention in TAA doc that a certain use case will lead to problems. #3317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e603928
Doc update.
FrancescoC-unity Feb 1, 2021
9cb5f68
Review feedback.
FrancescoC-unity Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions com.unity.render-pipelines.high-definition/Documentation~/Anti-Aliasing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ To select TAA for a Camera:
1. Select the Camera in the Scene view or Hierarchy and view it in the Inspector.
2. In the General section, select Temporal Anti-aliasing (TAA) from the Anti-aliasing drop-down.

When using the same Camera GameObject for multiple Game Views TAA may not work as expected due to limitations of the history buffer system. Multiple game views using different Cameras will however work as expected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add this into a "limitatoin section" : cc @JordanL8 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, a limitations section per anti-aliasing effect (when necessary) sounds good. For this one:

### Limitations
In the Editor, if multiple Game views use the same Camera, TAA may not work as expected due to limitations of the history buffer system. However, if you use multiple Game views, where each Game view uses a unique Camera, TAA works as expected.


### Limitations
In the Editor, if multiple Game views use the same Camera, TAA may not work as expected due to limitations of the history buffer system. However, if you use multiple Game views, where each Game view uses a unique Camera, TAA works as expected.


<a name="SMAA"></a>

## Subpixel morphological anti-aliasing (SMAA)
Expand Down